Use custom attribute to store blockquote depth on iOS #564
+26
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomekzaw
changed the title
markdownRanges on iOS
j-piasecki
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR removes
_blockquoteRangesAndLevelsinRCTMarkdownUtilsin favor of storing the blockquote depth asNSNumberunder custom attribute namedRCTLiveMarkdownBlockquoteDepth.This removes cohesion between
_blockquoteRangesAndLevelsandapplyRangeToAttributedString:which I plan to move to a separate class calledMarkdownFormatterin an upcoming PR.It also simplifies the implementation of
MarkdownLayoutManagerwhere now we can use[textStorage attribute:atIndex:effectiveRange:];to check if given range is a blockquote and determine its depth without custom algorithms.Partially applies #520.
Related Issues
GH_LINK
Manual Tests
Linked PRs